kaisun2000 commented on a change in pull request #1523:
URL: https://github.com/apache/helix/pull/1523#discussion_r521152549
##########
File path:
helix-core/src/main/java/org/apache/helix/common/caches/TaskDataCache.java
##########
@@ -267,6 +277,10 @@ public void updateWorkflowContext(String resourceName,
WorkflowContext workflowC
* Update context of the Workflow or Job
*/
private void updateContext(String resourceName, ZNRecord record) {
+ if (record != null && _initialContextMapHashcode.containsKey(resourceName)
+ &&
_initialContextMapHashcode.get(resourceName).equals((record.toString().hashCode())))
{
+ return;
+ }
Review comment:
I think MD5 is probably ok while hashcode is not. The thing is that even
in you doc you quote, it has around 'An aggregate collision rate of 8 per
10,000 still isn’t bad in an absolute sense.' 0.1% is still too high for our
usage.
MD5 etc secure hash is the foundation of digital signature. The have much
much lower false rate. Basically people can claim for all practical purpose,
they can replace equality test.
We can talk about it tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
