alirezazamani commented on a change in pull request #1520:
URL: https://github.com/apache/helix/pull/1520#discussion_r522406895
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/AttributeName.java
##########
@@ -48,5 +48,7 @@
// This attribute should only be used in TaskGarbageCollectionStage, misuse
could cause race conditions.
TO_BE_PURGED_WORKFLOWS,
// This attribute should only be used in TaskGarbageCollectionStage, misuse
could cause race conditions.
+ JOBS_WITHOUT_CONFIG,
Review comment:
I used the name you suggested at the beginning. Junkai asked for the
change and I think it makes sense to have a new name. TO_BE_PURGED_JOB causes
confusion between jobs without config and the expired job that have passed
their expiry time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
