alirezazamani commented on a change in pull request #1520:
URL: https://github.com/apache/helix/pull/1520#discussion_r522415598
##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
##########
@@ -1142,6 +1142,35 @@ public static void workflowGarbageCollection(final
Set<String> toBePurgedWorkflo
}
}
+ /**
+ * The function that removes IdealStates and job contexts of the jobs that
need to be
+ * deleted.
+ * @param toBePurgedJobs
+ * @param manager
+ */
+ public static void jobGarbageCollection(final Set<String> toBePurgedJobs,
Review comment:
They are different. Purged expiredJobs are for the jobs that exist in
the queue and they have workflow config. However, this is a general method to
delete the expired jobs whether they have workflow config or not, and also
whether the jobs are associated with a queue or regular workflow. Also, expired
jobs are for the queue that is currently running. If the queue has been deleted
and the job didn't get deleted for some reason, then this part will cover it
and does garbage collection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
