kaisun2000 commented on a change in pull request #1532:
URL: https://github.com/apache/helix/pull/1532#discussion_r541482955
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/IntermediateStateCalcStage.java
##########
@@ -259,14 +181,7 @@ private void validateMaxPartitionsPerInstance(ClusterEvent
event,
+ " mode due to an instance being assigned more
replicas/partitions than "
+ "the limit.");
}
-
- ClusterStatusMonitor clusterStatusMonitor =
- event.getAttribute(AttributeName.clusterStatusMonitor.name());
- if (clusterStatusMonitor != null) {
-
clusterStatusMonitor.setResourceRebalanceStates(Collections.singletonList(resource),
-
ResourceMonitor.RebalanceStatus.INTERMEDIATE_STATE_CAL_FAILED);
- }
- // Throw an exception here so that messages won't be sent out
based on this mapping
+ //TODO: add metrics
Review comment:
Feel free to skip the IntermediateStateCalcStage, the new logic is in
PerReplicaThrottleStage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
