pkuwm commented on a change in pull request #1532:
URL: https://github.com/apache/helix/pull/1532#discussion_r543886602
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/AttributeName.java
##########
@@ -48,7 +48,20 @@
// This attribute should only be used in TaskGarbageCollectionStage, misuse
could cause race conditions.
TO_BE_PURGED_WORKFLOWS,
// This attribute should only be used in TaskGarbageCollectionStage, misuse
could cause race conditions.
+
JOBS_WITHOUT_CONFIG,
// This attribute should only be used in TaskGarbageCollectionStage, misuse
could cause race conditions.
- TO_BE_PURGED_JOBS_MAP
+ TO_BE_PURGED_JOBS_MAP,
+
+ // This attribute denotes the messages output from Per Preplica Throttle
stage
+ PER_REPLICA_OUTPUT_MESSAGES,
+
+ // This attribute denotes the targeted partition state mapping from Per
Preplica Throttle stage
+ PER_REPLICA_RETRACED_STATES,
+
+ // This attribute denotes the filtered out messages deemed as recovery
message
+ PER_REPLICA_THROTTLED_RECOVERY_MESSAGES,
+
+ // This attribute denotes the filtered out messages deemed as load message
+ PER_REPLICA_THOTTLED_LOAD_MESSAGES
Review comment:
Typo: `PER_REPLICA_THOTTLED_LOAD_MESSAGES` ->
`PER_REPLICA_THROTTLED_LOAD_MESSAGES`
##########
File path:
helix-core/src/test/java/org/apache/helix/mock/participant/MockOFModelFactory.java
##########
@@ -0,0 +1,53 @@
+package org.apache.helix.mock.participant;
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.helix.participant.statemachine.StateModelFactory;
+
+// mock online offline state model factory
+public class MockOFModelFactory extends StateModelFactory<MockOFStateModel> {
+ private MockTransition _transition;
+
+ public MockOFModelFactory() {
+ this(null);
+ }
+
+ public MockOFModelFactory(MockTransition transition) {
+ _transition = transition;
+ }
+
+ public void setTrasition(MockTransition transition) {
Review comment:
Typo. `setTrasition` -> `setTransition`
##########
File path: helix-core/src/test/java/org/apache/helix/mock/MockHelixAdmin.java
##########
@@ -45,6 +47,8 @@
import org.apache.helix.model.ResourceConfig;
import org.apache.helix.model.StateModelDefinition;
import org.apache.helix.zookeeper.datamodel.ZNRecord;
+import sun.applet.Main;
Review comment:
Remove the unused imports in this file/PR?
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/resource/ResourceMessageGenerationPhase.java
##########
@@ -19,7 +19,9 @@
* under the License.
*/
+import org.apache.helix.controller.common.ResourcesStateMap;
import org.apache.helix.controller.stages.AttributeName;
+import org.apache.helix.controller.stages.BestPossibleStateOutput;
Review comment:
This import is unused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
