xyuanlu commented on a change in pull request #1756:
URL: https://github.com/apache/helix/pull/1756#discussion_r640223491
##########
File path: helix-core/src/main/java/org/apache/helix/util/HelixUtil.java
##########
@@ -295,7 +352,6 @@ public static String serializeByComma(List<String> objects)
{
LOG.error("getIdealAssignmentForWagedFullAuto(): Failed to compute
ResourceAssignments!", e);
} finally {
// Close all ZK connections
- baseDataAccessor.close();
readOnlyWagedRebalancer.close();
Review comment:
If we pass a baseDataAccessor created by caller, then that accessor
should not be closed here. readOnlyWagedRebalancer is created in this function
so we close it in final block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
