jiajunwang commented on a change in pull request #1756:
URL: https://github.com/apache/helix/pull/1756#discussion_r640283326



##########
File path: helix-core/src/main/java/org/apache/helix/util/HelixUtil.java
##########
@@ -295,7 +352,6 @@ public static String serializeByComma(List<String> objects) 
{
       LOG.error("getIdealAssignmentForWagedFullAuto(): Failed to compute 
ResourceAssignments!", e);
     } finally {
       // Close all ZK connections
-      baseDataAccessor.close();
       readOnlyWagedRebalancer.close();

Review comment:
       For helix-reset, the caller create the accessor and passed in, right? So 
it is not created in this function.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to