qqu0127 opened a new pull request #1935: URL: https://github.com/apache/helix/pull/1935
### Description - [x] Here are some details about my PR, including screenshots of any UI changes: Implement the java endpoint for adding virtual topology group for a cluster. The entry point is `VirtualTopologyGroupService#addVirtualTopologyGroup`. This provides an extra layer in cluster topology named "virtual_zone" so that we have more control over it and can change the number and assignment on the fly. This also decouples the setup from physical fault domain so it's no longer a restriction. This API is only expected to be invoked in cloud environment where `cloudConfig.isCloudEnabled()` is true. Besides, a new cluster config is introduced: `VIRTUAL_GROUP_ENABLED` to enable this feature. An algorithm for assigning virtual topology group is introduced in `VirtualTopologyGroupStrategy`. It takes the cluster topology and assigns virtual zone for each instance under a cluster. Instance configs are then updated asynchronously. The operation is NOT transactional, but there are internal retry logic, maintenance mode will also be enabled during the process. TODO in the following commits and PRs: 1. Implement REST API 2. Integration test 3. Documentation and user manual ### Tests - [x] The following tests are written for this issue: `TestVirtualTopologyGroup` `TestVirtualTopologyGroupService` - The following is the result of the "mvn test" command on the appropriate module: [INFO] Tests run: 196, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 208.515 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 196, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] --- jacoco-maven-plugin:0.8.6:report (generate-code-coverage-report) @ helix-rest --- [INFO] Loading execution data file /Users/qqu/workspace/qqu-helix/helix-rest/target/jacoco.exec [INFO] Analyzed bundle 'Apache Helix :: Restful Interface' with 87 classes [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 03:34 min [INFO] Finished at: 2022-01-14T14:25:42-08:00 [INFO] ------------------------------------------------------------------------ ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
