narendly commented on a change in pull request #1935: URL: https://github.com/apache/helix/pull/1935#discussion_r787230750
########## File path: helix-core/src/main/java/org/apache/helix/controller/VirtualTopologyGroupStrategy.java ########## @@ -0,0 +1,80 @@ +package org.apache.helix.controller; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import com.google.common.collect.ImmutableMap; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import org.apache.helix.util.HelixUtil; + +public enum VirtualTopologyGroupStrategy { Review comment: Could `VirtualTopologyGroupStrategy` have multiple implementations and do we expect to add different implementations and make this configurable? If so, I think using an abstract base class could also work. Or is the goal to provide a static method? if so i think a util class would fit better here. Since this is only used in `VirtualTopologyGroupService` and only fixed to a `DEFAULT` implementation. Is this class only going to be used in Helix REST? If that's the case, I'd place this in that module. I'm confused because I'm not sure what the intent of this class is - it also has an abstract method and the default enum is a behavior (verb) than named variables (nouns) that enums generally are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
