qqu0127 opened a new pull request #2011: URL: https://github.com/apache/helix/pull/2011
### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: Fixes #1980 ### Description Attempt to fix TestDropResourceMetricsReset -- register ExternalViewComputeStage to IdealStateChange. The test failure could be reproduced stably using **either ZK version** by adding Thread.sleep() between `participant.syncStop()` and `setupTool.dropResourceFromCluster`. So this indicates the test was wrong (and succeeded in a wrong way) for a while, there are race condition and zk version change introduce unrelated delay that finally reveal the issue. mBean is only unregistered during ExternalViewComputeStage in https://github.com/apache/helix/blob/master/helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java#L99. It's not always happening after the resource is dropped as there is no `CurrentStateChange` event anymore, only `IdealStateChange`. This PR register ExternalViewComputeStage to IdealStateChange to make bean unregistration happens. ### Tests - [ ] The following tests are written for this issue: (List the names of added unit/integration tests) - The following is the result of the "mvn test" command on the appropriate module: (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.) ### Changes that Break Backward Compatibility (Optional) - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.) ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
