desaikomal commented on a change in pull request #2011:
URL: https://github.com/apache/helix/pull/2011#discussion_r840991272



##########
File path: 
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -552,7 +552,7 @@ private static PipelineRegistry 
createDefaultRegistry(String pipelineName) {
       autoExitMaintenancePipeline.addStage(new MaintenanceRecoveryStage());
 
       registry.register(ClusterEventType.IdealStateChange, dataRefresh, 
dataPreprocess,
-          rebalancePipeline);
+          externalViewPipeline, rebalancePipeline);

Review comment:
       It is non-deterministic test which we all agree as test is not failing 
consistently in CI. Just curious, changing the code is the right behavior or 
should mock<> implementation of controller needs to change?? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to