mgao0 commented on code in PR #2015:
URL: https://github.com/apache/helix/pull/2015#discussion_r843053284
##########
helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java:
##########
@@ -287,11 +267,18 @@ public void setInstanceEnabled(boolean enabled) {
_record.setLongField(InstanceConfigProperty.HELIX_ENABLED_TIMESTAMP.name(),
System.currentTimeMillis());
if (enabled) {
-
_record.getSimpleFields().remove(InstanceConfigProperty.HELIX_DISABLED_REASON.toString());
-
_record.getSimpleFields().remove(InstanceConfigProperty.HELIX_DISABLED_TYPE.toString());
+ resetInstanceDisabledTypeAndReason();
}
}
+ /**
+ * Removes HELIX_DISABLED_REASON and HELIX_DISABLED_TYPE entry from simple
field.
+ */
+ public void resetInstanceDisabledTypeAndReason() {
Review Comment:
Can we make this a private method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
