xyuanlu commented on code in PR #2015:
URL: https://github.com/apache/helix/pull/2015#discussion_r843097646
##########
helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java:
##########
@@ -327,7 +314,7 @@ public String getInstanceDisabledReason() {
*/
public String getInstanceDisabledType() {
if (getInstanceEnabled()) {
- return
InstanceConstants.InstanceDisabledType.INSTANCE_NOT_DISABLED.toString();
+ return InstanceConstants.INSTANCE_NOT_DISABLED;
Review Comment:
Yes. It would be confusing for user to see "INSTANCE_NOT_DISABLED" in
InstanceDisabledType. I use to a separate static String to represent not
enabled instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
