richardstartin opened a new pull request, #2072: URL: https://github.com/apache/helix/pull/2072
…ZNRecord ### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fixes #1970 ### Description In Apache Pinot, we first deserialize `ZNRecord`s and then construct `HelixProperty`s from them, and never use the `ZNRecord` again. `HelixProperty` makes a defensive copy of the `ZNRecord`, which is actually expensive enough to show up prominently in profiles of our helix threads. This change adds constructors to `HelixConstructor` which do not clone the `ZNRecord`. Backward compatibility is maintained, and all existing code will continue to clone the `ZNRecord`, but new code can be written to set the `clone` to false to avoid the expensive copy. ### Tests No tests have been added as this change is trivial. ### Changes that Break Backward Compatibility (Optional) Backward compatibility has been maintained. Existing code continues to clone the `ZNRecord`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
