richardstartin commented on code in PR #2072:
URL: https://github.com/apache/helix/pull/2072#discussion_r861163459
##########
helix-core/src/main/java/org/apache/helix/HelixProperty.java:
##########
@@ -156,25 +156,50 @@ public String toString() {
* @param id
*/
public HelixProperty(String id) {
- this(new ZNRecord(id), id);
+ this(new ZNRecord(id), id, false);
Review Comment:
@junkaixue default value is false here because there is no need to make a
copy of an `ZNRecord` the caller hasn't passed in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
