narendly commented on code in PR #2072:
URL: https://github.com/apache/helix/pull/2072#discussion_r861172247
##########
helix-core/src/main/java/org/apache/helix/HelixProperty.java:
##########
@@ -39,7 +39,7 @@
* A wrapper class for ZNRecord. Used as a base class for IdealState,
CurrentState, etc.
*/
public class HelixProperty {
Review Comment:
Yes, I understand the motivation behind this. That still doesn't give us a
way to tell if the object is thoroughly immutable (because the underlying
ZNRecord has been deep-copied) - I was thinking maybe adding a final `boolean`
that can tell us whether it's mutable or immutable? Do you think that would be
useful for the users of `HelixProperty`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
