micahstubbs commented on issue #2095: URL: https://github.com/apache/helix/issues/2095#issuecomment-1128338108
```py npm run lint > [email protected] lint /helix/helix-front > ng lint Linting "helix-front"... no-use-before-declare is deprecated. Since TypeScript 2.9. Please use the built-in compiler checks instead. typeof-compare is deprecated. Starting from TypeScript 2.2 the compiler includes this check which makes this rule redundant. Could not find implementations for the following rules specified in the configuration: use-input-property-decorator use-output-property-decorator use-host-property-decorator Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed. If TSLint was recently upgraded, you may have old rules configured which need to be cleaned up. /helix/helix-front/client/app/app.component.ts:60:27 ERROR: 60:27 triple-equals == should be === ERROR: 91:41 quotemark " should be ' /helix/helix-front/client/app/cluster/cluster-list/cluster-list.component.ts:19:17 ERROR: 19:17 no-inferrable-types Type string trivially inferred from a string literal, remove type annotation ERROR: 20:14 no-inferrable-types Type boolean trivially inferred from a boolean literal, remove type annotation ERROR: 21:8 no-inferrable-types Type boolean trivially inferred from a boolean literal, remove type annotation /helix/helix-front/client/app/cluster/cluster.component.ts:27:1 ERROR: 27:1 no-trailing-whitespace trailing whitespace /helix/helix-front/client/app/cluster/shared/cluster.model.ts:26:9 ERROR: 26:9 prefer-const Identifier 'ins' is never reassigned; use 'const' instead of 'let'. ERROR: 27:14 prefer-const Identifier 'instance' is never reassigned; use 'const' instead of 'let'. /helix/helix-front/client/app/configuration/config-detail/config-detail.component.ts:58:21 ERROR: 58:21 triple-equals != should be !== /helix/helix-front/client/app/core/helix.service.ts:74:9 ERROR: 74:9 prefer-const Identifier 'headers' is never reassigned; use 'const' instead of 'let'. ERROR: 86:24 triple-equals == should be === /helix/helix-front/client/app/core/user.service.ts:34:9 ERROR: 34:9 prefer-const Identifier 'headers' is never reassigned; use 'const' instead of 'let'. /helix/helix-front/client/app/dashboard/dashboard.component.ts:30:24 ERROR: 30:24 no-trailing-whitespace trailing whitespace ERROR: 42:16 whitespace missing whitespace ERROR: 75:21 triple-equals == should be === ERROR: 85:17 no-trailing-whitespace trailing whitespace ERROR: 134:9 prefer-const Identifier 'width' is never reassigned; use 'const' instead of 'let'. ERROR: 135:9 prefer-const Identifier 'height' is never reassigned; use 'const' instead of 'let'. ERROR: 136:9 prefer-const Identifier 'dashboardDom' is never reassigned; use 'const' instead of 'let'. ERROR: 151:16 no-shadowed-variable Shadowed name: '_' ERROR: 258:27 no-shadowed-variable Shadowed name: 'instanceName' /helix/helix-front/client/app/history/history-list/history-list.component.ts:39:11 ERROR: 39:11 prefer-const Identifier 'clusterName' is never reassigned; use 'const' instead of 'let'. ERROR: 40:11 prefer-const Identifier 'instanceName' is never reassigned; use 'const' instead of 'let'. ERROR: 41:11 prefer-const Identifier 'observable' is never reassigned; use 'const' instead of 'let'. ERROR: 57:24 triple-equals == should be === ERROR: 63:24 triple-equals == should be === /helix/helix-front/client/app/history/shared/history.service.ts:26:9 ERROR: 26:9 prefer-const Identifier 'histories' is never reassigned; use 'const' instead of 'let'. ERROR: 29:16 prefer-const Identifier 'record' is never reassigned; use 'const' instead of 'let'. ERROR: 32:13 prefer-const Identifier 'history' is never reassigned; use 'const' instead of 'let'. ERROR: 34:18 prefer-const Identifier 'seg' is never reassigned; use 'const' instead of 'let'. ERROR: 35:15 prefer-const Identifier 'name' is never reassigned; use 'const' instead of 'let'. ERROR: 36:15 prefer-const Identifier 'value' is never reassigned; use 'const' instead of 'let'. ERROR: 37:20 triple-equals == should be === ERROR: 39:27 triple-equals == should be === ERROR: 41:27 triple-equals == should be === ERROR: 43:27 triple-equals == should be === /helix/helix-front/client/app/instance/instance-list/instance-list.component.ts:46:9 ERROR: 46:9 prefer-const Identifier 'row' is never reassigned; use 'const' instead of 'let'. /helix/helix-front/client/app/instance/shared/instance.service.ts:39:92 ERROR: 39:92 triple-equals != should be !== ERROR: 55:9 prefer-const Identifier 'node' is never reassigned; use 'const' instead of 'let'. /helix/helix-front/client/app/resource/resource-list/resource-list.component.ts:91:1 ERROR: 91:1 max-line-length Exceeds maximum line length of 140 /helix/helix-front/client/app/resource/shared/resource.model.ts:14:92 ERROR: 14:92 triple-equals != should be !== ERROR: 45:65 triple-equals != should be !== ERROR: 70:5 forin for (... in ...) statements must be filtered with an if statement ERROR: 70:14 prefer-const Identifier 'partitionName' is never reassigned; use 'const' instead of 'let'. ERROR: 71:11 prefer-const Identifier 'partition' is never reassigned; use 'const' instead of 'let'. ERROR: 75:30 triple-equals != should be !== ERROR: 76:18 prefer-const Identifier 'replicaName' is never reassigned; use 'const' instead of 'let'. ERROR: 83:37 triple-equals != should be !== ERROR: 84:9 forin for (... in ...) statements must be filtered with an if statement ERROR: 84:18 prefer-const Identifier 'replicaName' is never reassigned; use 'const' instead of 'let'. ERROR: 92:9 forin for (... in ...) statements must be filtered with an if statement ERROR: 92:18 prefer-const Identifier 'replicaName' is never reassigned; use 'const' instead of 'let'. /helix/helix-front/client/app/resource/shared/resource.service.ts:18:13 ERROR: 18:13 prefer-const Identifier 'res' is never reassigned; use 'const' instead of 'let'. ERROR: 19:18 prefer-const Identifier 'name' is never reassigned; use 'const' instead of 'let'. ERROR: 34:13 prefer-const Identifier 'res' is never reassigned; use 'const' instead of 'let'. ERROR: 36:20 prefer-const Identifier 'resource' is never reassigned; use 'const' instead of 'let'. ERROR: 64:13 prefer-const Identifier 'ret' is never reassigned; use 'const' instead of 'let'. ERROR: 72:9 forin for (... in ...) statements must be filtered with an if statement ERROR: 72:18 prefer-const Identifier 'partition' is never reassigned; use 'const' instead of 'let'. ERROR: 73:15 prefer-const Identifier 'par' is never reassigned; use 'const' instead of 'let'. /helix/helix-front/client/app/shared/data-table/data-table.component.ts:48:9 ERROR: 48:9 prefer-const Identifier 'data' is never reassigned; use 'const' instead of 'let'. /helix/helix-front/client/app/shared/input-inline/input-inline.component.ts:13:3 ERROR: 13:3 no-output-rename @Outputs should not be renamed ERROR: 15:19 no-inferrable-types Type string trivially inferred from a string literal, remove type annotation ERROR: 16:17 no-inferrable-types Type number trivially inferred from a number literal, remove type annotation ERROR: 17:17 no-inferrable-types Type number trivially inferred from a number literal, remove type annotation ERROR: 18:23 no-inferrable-types Type number trivially inferred from a number literal, remove type annotation ERROR: 19:23 no-inferrable-types Type number trivially inferred from a number literal, remove type annotation ERROR: 20:18 no-inferrable-types Type string trivially inferred from a string literal, remove type annotation ERROR: 21:22 no-inferrable-types Type boolean trivially inferred from a boolean literal, remove type annotation ERROR: 24:3 member-ordering Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface. ERROR: 25:3 member-ordering Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface. ERROR: 25:24 no-inferrable-types Type string trivially inferred from a string literal, remove type annotation ERROR: 26:3 member-ordering Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface. ERROR: 26:23 no-inferrable-types Type string trivially inferred from a string literal, remove type annotation ERROR: 27:3 member-ordering Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface. ERROR: 27:22 no-inferrable-types Type boolean trivially inferred from a boolean literal, remove type annotation ERROR: 29:3 member-ordering Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface. ERROR: 29:12 no-inferrable-types Type boolean trivially inferred from a boolean literal, remove type annotation ERROR: 31:3 member-ordering Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface. ERROR: 31:19 no-inferrable-types Type string trivially inferred from a string literal, remove type annotation ERROR: 43:3 member-ordering Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface. ERROR: 43:22 no-inferrable-types Type string trivially inferred from a string literal, remove type annotation ERROR: 46:3 member-ordering Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface. ERROR: 47:3 member-ordering Declaration of instance field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface. /helix/helix-front/client/app/shared/json-viewer/json-viewer.component.spec.ts:12:15 ERROR: 12:15 whitespace missing whitespace /helix/helix-front/client/app/shared/json-viewer/json-viewer.component.ts:21:11 ERROR: 21:11 prefer-const Identifier 'path' is never reassigned; use 'const' instead of 'let'. /helix/helix-front/client/app/shared/key-value-pairs/key-value-pairs.component.ts:7:24 ERROR: 7:24 directive-selector The selector should be used as an attribute (https://angular.io/guide/styleguide#style-02-06) ERROR: 8:35 one-line missing whitespace /helix/helix-front/client/app/shared/material.module.ts:102:32 ERROR: 102:32 eofline file should end with a newline /helix/helix-front/client/app/shared/models/node.model.ts:76:9 ERROR: 76:9 prefer-const Identifier 'obj' is never reassigned; use 'const' instead of 'let'. /helix/helix-front/client/app/shared/node-viewer/node-viewer.component.ts:26:3 ERROR: 26:3 no-output-rename @Outputs should not be renamed ERROR: 29:3 no-output-rename @Outputs should not be renamed ERROR: 32:3 no-output-rename @Outputs should not be renamed ERROR: 183:15 prefer-const Identifier 'newNode' is never reassigned; use 'const' instead of 'let'. ERROR: 212:9 prefer-const Identifier 'newNode' is never reassigned; use 'const' instead of 'let'. ERROR: 226:9 prefer-const Identifier 'newNode' is never reassigned; use 'const' instead of 'let'. ERROR: 228:11 whitespace missing whitespace ERROR: 236:1 max-line-length Exceeds maximum line length of 140 ERROR: 243:1 max-line-length Exceeds maximum line length of 140 ERROR: 253:1 max-line-length Exceeds maximum line length of 140 ERROR: 272:9 prefer-const Identifier 'newNode' is never reassigned; use 'const' instead of 'let'. ERROR: 274:11 whitespace missing whitespace ERROR: 282:1 max-line-length Exceeds maximum line length of 140 ERROR: 287:1 max-line-length Exceeds maximum line length of 140 ERROR: 292:1 max-line-length Exceeds maximum line length of 140 ERROR: 297:1 max-line-length Exceeds maximum line length of 140 ERROR: 310:1 max-line-length Exceeds maximum line length of 140 /helix/helix-front/client/app/workflow/job-detail/job-detail.component.spec.ts:5:29 ERROR: 5:29 rxjs-proper-imports outdated import path /helix/helix-front/client/app/workflow/job-list/job-list.component.ts:39:19 ERROR: 39:19 radix Missing radix parameter /helix/helix-front/client/app/workflow/shared/workflow.model.ts:50:90 ERROR: 50:90 triple-equals == should be === ERROR: 67:9 prefer-const Identifier 'result' is never reassigned; use 'const' instead of 'let'. /helix/helix-front/client/app/workflow/workflow-dag/workflow-dag.component.ts:28:28 ERROR: 28:28 whitespace missing whitespace /helix/helix-front/client/testing/testing.module.ts:8:45 ERROR: 8:45 whitespace missing whitespace Lint errors found in the listed files. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
