micahstubbs commented on issue #2095: URL: https://github.com/apache/helix/issues/2095#issuecomment-1128339983
Let's fix the errors that can be automatically fixed with `ng lint -- --fix`: ```py npm run lint:fix > [email protected] lint:fix /helix/helix-front > ng lint -- --fix Linting "helix-front"... no-use-before-declare is deprecated. Since TypeScript 2.9. Please use the built-in compiler checks instead. typeof-compare is deprecated. Starting from TypeScript 2.2 the compiler includes this check which makes this rule redundant. Could not find implementations for the following rules specified in the configuration: use-input-property-decorator use-output-property-decorator use-host-property-decorator Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed. If TSLint was recently upgraded, you may have old rules configured which need to be cleaned up. /helix/helix-front/client/app/app.component.ts:60:27 ERROR: 60:27 triple-equals == should be === /helix/helix-front/client/app/configuration/config-detail/config-detail.component.ts:58:21 ERROR: 58:21 triple-equals != should be !== /helix/helix-front/client/app/core/helix.service.ts:86:24 ERROR: 86:24 triple-equals == should be === /helix/helix-front/client/app/dashboard/dashboard.component.ts:75:21 ERROR: 75:21 triple-equals == should be === ERROR: 151:16 no-shadowed-variable Shadowed name: '_' ERROR: 258:27 no-shadowed-variable Shadowed name: 'instanceName' /helix/helix-front/client/app/history/history-list/history-list.component.ts:57:24 ERROR: 57:24 triple-equals == should be === ERROR: 63:24 triple-equals == should be === /helix/helix-front/client/app/history/shared/history.service.ts:37:20 ERROR: 37:20 triple-equals == should be === ERROR: 39:27 triple-equals == should be === ERROR: 41:27 triple-equals == should be === ERROR: 43:27 triple-equals == should be === /helix/helix-front/client/app/instance/shared/instance.service.ts:39:92 ERROR: 39:92 triple-equals != should be !== /helix/helix-front/client/app/resource/resource-list/resource-list.component.ts:91:1 ERROR: 91:1 max-line-length Exceeds maximum line length of 140 /helix/helix-front/client/app/resource/shared/resource.model.ts:14:92 ERROR: 14:92 triple-equals != should be !== ERROR: 45:65 triple-equals != should be !== ERROR: 70:5 forin for (... in ...) statements must be filtered with an if statement ERROR: 75:30 triple-equals != should be !== ERROR: 83:37 triple-equals != should be !== ERROR: 84:9 forin for (... in ...) statements must be filtered with an if statement ERROR: 92:9 forin for (... in ...) statements must be filtered with an if statement /helix/helix-front/client/app/resource/shared/resource.service.ts:72:9 ERROR: 72:9 forin for (... in ...) statements must be filtered with an if statement /helix/helix-front/client/app/shared/input-inline/input-inline.component.ts:24:3 ERROR: 24:3 no-output-rename @Outputs should not be renamed /helix/helix-front/client/app/shared/key-value-pairs/key-value-pairs.component.ts:7:24 ERROR: 7:24 directive-selector The selector should be used as an attribute (https://angular.io/guide/styleguide#style-02-06) /helix/helix-front/client/app/shared/node-viewer/node-viewer.component.ts:26:3 ERROR: 26:3 no-output-rename @Outputs should not be renamed ERROR: 29:3 no-output-rename @Outputs should not be renamed ERROR: 32:3 no-output-rename @Outputs should not be renamed ERROR: 236:1 max-line-length Exceeds maximum line length of 140 ERROR: 243:1 max-line-length Exceeds maximum line length of 140 ERROR: 253:1 max-line-length Exceeds maximum line length of 140 ERROR: 282:1 max-line-length Exceeds maximum line length of 140 ERROR: 287:1 max-line-length Exceeds maximum line length of 140 ERROR: 292:1 max-line-length Exceeds maximum line length of 140 ERROR: 297:1 max-line-length Exceeds maximum line length of 140 ERROR: 310:1 max-line-length Exceeds maximum line length of 140 /helix/helix-front/client/app/workflow/job-detail/job-detail.component.spec.ts:2:1 ERROR: 2:1 rxjs-collapse-imports duplicate RxJS import /helix/helix-front/client/app/workflow/job-list/job-list.component.ts:39:19 ERROR: 39:19 radix Missing radix parameter /helix/helix-front/client/app/workflow/shared/workflow.model.ts:50:90 ERROR: 50:90 triple-equals == should be === Lint errors found in the listed files. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
