xyuanlu commented on code in PR #2134:
URL: https://github.com/apache/helix/pull/2134#discussion_r888253742
##########
helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java:
##########
@@ -120,17 +121,17 @@ public static String
getInstanceHelixDisabledType(HelixDataAccessor dataAccessor
* @param clusterConfig
* @return
*/
- public static boolean isInstanceEnabled(InstanceConfig instanceConfig,
ClusterConfig clusterConfig) {
+ public static boolean isInstanceEnabled(InstanceConfig instanceConfig,
@Nullable ClusterConfig clusterConfig) {
if (instanceConfig == null) {
Review Comment:
I feel like marking nullable for clusterConfig is a bit conflict with
`isEnabled()` line 78. As we are throwing exception if clusterConfig is null.
Probably we want to keep the same behavior..?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
