qqu0127 commented on code in PR #2134:
URL: https://github.com/apache/helix/pull/2134#discussion_r888263195


##########
helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java:
##########
@@ -120,17 +121,17 @@ public static String 
getInstanceHelixDisabledType(HelixDataAccessor dataAccessor
    * @param clusterConfig

Review Comment:
   I don't get it. Method `getInstanceHelixDisabledType` is reading 
clusterConfig for disabled type. How can we not read from cluster config?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to