micahstubbs opened a new pull request, #2144:
URL: https://github.com/apache/helix/pull/2144

   ### Issues
   
   - [ ] My PR addresses the following Helix issues and references them in the 
PR description:
   
   # fix 2075
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   This PR fixes the end to end tests by replacing the [deprecated Protractor 
library](https://github.com/angular/protractor/issues/5502) with 
[Cypress](https://docs.cypress.io/guides/end-to-end-testing/protractor-to-cypress?cli=true).
 
   
   This PR also replaces karma and jasmine with 
[Jest](https://jestjs.io/docs/migration-guide) [[Jest + Angular 
guide](https://dev.to/kiranmantha/integrating-jest-with-latest-angular-version-4h4m)].
 
   
   <img width="814" alt="Screen Shot 2022-06-07 at 1 37 52 PM" 
src="https://user-images.githubusercontent.com/2119400/172481203-25ae5002-b13b-4171-9ec7-621b72ef3984.png";>
   
   
   ### Tests
   
   - [x] The following tests are written for this issue:
   
   ```
   cypress/e2e/spec.cy.ts
   ```
   
   [x] The following is the result of the "mvn test" command on the appropriate 
module: 
   
   N/A, helix-front only change. No Java changes.
   
   ### Changes that Break Backward Compatibility 
   
   [x] No backwards incompatible changes
   
   ### Documentation 
   
   [x] New commands documented in 
[./helix-front/README.md](./helix-front/README.md)
   
   ### Commits
   
   [x] Commits match Apache style 
   
   ### Code Quality
   
   [x] My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   
   N/A, helix-front only change. No Java changes.  See #2143 for an effort to 
add automatic code formatting for helix-front.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to