micahstubbs commented on code in PR #2144:
URL: https://github.com/apache/helix/pull/2144#discussion_r891706847
##########
helix-front/client/app/dashboard/dashboard.component.ts:
##########
@@ -169,7 +170,7 @@ export class DashboardComponent implements OnInit,
AfterViewInit, OnDestroy {
.getAll(this.clusterName)
.subscribe(
result => {
- _.forEach(result, (resource) => {
+ lodashForEach(result, (resource) => {
Review Comment:
A workaround for this TypeScript related error:
https://stackoverflow.com/q/49256040/1732222
A secondary benefit of this approach is new contributors will be less likely
to confuse lodash's forEach with the native TypeScript `Array.forEach()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]