xyuanlu commented on PR #2201: URL: https://github.com/apache/helix/pull/2201#issuecomment-1242561175
> > For line 2069 in [ZkClient.java](https://github.com/apache/helix/pull/2201/files#diff-c20891e1adafdc5bd7c55936d81ec52e84081b76f7df3759da762f932d3f1cae), we should remove `if (LOG.isDebugEnabled()) {` It is redundant. > > This is in general to avoid error message computing (if applicable), like format. Not necessarily redundent. But IMO, I think it looks ugly and does not really save much, I vote for removing them : ) Please correct me if I am wrong. I think with the correct log formatter, log4j will do lazily log message construction. We should also do this kind of log improvement for Helix as well.... link: https://logging.apache.org/log4j/2.x/manual/api.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
