jiajunwang commented on code in PR #2201:
URL: https://github.com/apache/helix/pull/2201#discussion_r965107256
##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -2073,7 +2073,7 @@ public Object call() throws Exception {
record(path, null, startT, ZkClientMonitor.AccessType.WRITE);
} catch (Exception e) {
recordFailure(path, ZkClientMonitor.AccessType.WRITE);
- LOG.warn("zkclient {}, Failed to delete path {}! ", _uid, path, e);
+ LOG.info("zkclient {}, Failed to delete path {}! ", _uid, path, e);
Review Comment:
Since exception is thrown, we don't really need to log it. I would suggest
to get rid of this line completely to resolve the concern.
I would be great to revisit all the similar spots too.
1. If error will be thrown, no need to log. The caller can log if necessary.
2. If the error will be handled within the method, then log properly
assuming it provides additional information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
