xyuanlu commented on code in PR #2208:
URL: https://github.com/apache/helix/pull/2208#discussion_r972496932
##########
helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java:
##########
@@ -393,9 +393,6 @@ public AccessResult doSet(String path, T record, int
expectVersion, int options)
result._retCode = RetCode.ERROR;
return result;
}
- } catch (ZkBadVersionException e) {
- LOG.debug("Exception while setting path: " + path, e);
- throw e;
Review Comment:
we may introduce a behavior change here. As now when we get
`ZkBadVersionException`, it will go to general exception branch.
##########
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java:
##########
@@ -781,9 +781,6 @@ void createClient() throws Exception {
*/
handleNewSession(ZKUtil.toHexSessionId(sessionId));
break;
- } catch (HelixException e) {
- LOG.error("fail to createClient.", e);
- throw e;
Review Comment:
Same here. We may have behavior change introduced here..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
