xyuanlu commented on code in PR #2208:
URL: https://github.com/apache/helix/pull/2208#discussion_r973488022
##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java:
##########
@@ -274,13 +274,8 @@ private Response batchGetStoppableInstances(String
clusterId, JsonNode node, boo
return JSONRepresentation(result);
} catch (HelixException e) {
_logger
- .error(String.format("Current cluster %s has issue with health
checks!", clusterId), e);
+ .error(String.format("Current cluster %s has issue with health
checks!", clusterId), e);
throw new HelixHealthException(e);
- } catch (Exception e) {
- _logger.error(String.format(
- "Failed to get parallel stoppable instances for cluster %s with
a HelixException!",
- clusterId), e);
Review Comment:
Let's keep the log here? Logging the cluster name will be helpful when we
debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
