cliffordfajardo commented on code in PR #2238:
URL: https://github.com/apache/helix/pull/2238#discussion_r999698338


##########
helix-front/server/config.example.ts:
##########
@@ -5,20 +5,21 @@ export const HELIX_ENDPOINTS = {
     },
   ],
 };
-
 export const SESSION_STORE = undefined;
-
 export const SSL = {
   port: 0,
   keyfile: '',
   certfile: '',
   passfile: '',
   cafiles: [],
 };
-
 export const LDAP = {
   uri: 'ldap://example.com',
   base: 'DC=example,DC=com',
   principalSuffix: '@example.com',
   adminGroup: 'admin',
 };
+
+export const IDENTITY_TOKEN_SOURCE = undefined; // 'www.example.com';
+export const CUSTOM_IDENTITY_TOKEN_REQUEST_BODY = {};

Review Comment:
   Are there specific attributes that are required to be present for  
`CUSTOM_IDENTITY_TOKEN_REQUEST_BODY`
   
   
   Does it make sense to add a `type` or `interface for 
`CUSTOM_IDENTITY_TOKEN_REQUEST_BODY`
   Example
   ```
   export const CUSTOM_IDENTITY_TOKEN_REQUEST_BODY: {some_inline_type} = {};
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to