micahstubbs commented on code in PR #2238:
URL: https://github.com/apache/helix/pull/2238#discussion_r999747263
##########
helix-front/server/controllers/d.ts:
##########
@@ -5,6 +5,7 @@ export interface HelixUserRequest extends Request {
}
interface HelixSession {
+ identityToken: any;
Review Comment:
I would generally agree, however since this token format is
user-customizable, this really is `any` from helix-front's point of view.
helix-front doesn't know what Identity Source it will be used with, or what
type that Identity Source's identityToken will be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
