junkaixue commented on code in PR #2249:
URL: https://github.com/apache/helix/pull/2249#discussion_r1009771006
##########
meta-client/src/main/java/org/apache/helix/metaclient/api/MetaClientInterface.java:
##########
@@ -20,27 +20,36 @@
*/
import java.util.List;
+import java.util.concurrent.TimeUnit;
public interface MetaClientInterface<T> {
enum EntryMode {
//The node will be removed automatically when the session associated with
the creation
// of the node expires.
- EPHEMERAL,
- //The node will not be automatically deleted upon client's disconnect.
+ EPHEMERAL, //The node will not be automatically deleted upon client's
disconnect.
PERSISTENT
}
+ enum ConnectState {
Review Comment:
Have we considered session concept before? If not , how we simulate session?
##########
meta-client/src/main/java/org/apache/helix/metaclient/factories/MetaClientConfig.java:
##########
@@ -0,0 +1,115 @@
+package org.apache.helix.metaclient.factories;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+class MetaClientConfig {
+
+ public enum StoreType {
+ ZOOKEEPER, ETCD
Review Comment:
Better need a customized mode?
##########
meta-client/src/main/java/org/apache/helix/metaclient/api/DirectChildrenChangeListener.java:
##########
@@ -0,0 +1,29 @@
+package org.apache.helix.metaclient.api;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*
+ * Listener interface for direct children change event on a particular key. It
includes new subentry creation or subentry deletion. The callback won't
differentiate these types.
+ * For hierarchy key spaces like zookeeper, it refers to an entry's direct
children nodes.
+ * For flat key spaces, it refers to keys that matches `prefix*separator`.
+ */
+public interface DirectChildrenChangeListener {
Review Comment:
Why we need this? Children change listener can be recursively subscribe if
it is hierarchy model
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
