qqu0127 commented on code in PR #2249: URL: https://github.com/apache/helix/pull/2249#discussion_r1017077880
########## meta-client/src/main/java/org/apache/helix/metaclient/api/DataChangeListener.java: ########## @@ -0,0 +1,33 @@ +package org.apache.helix.metaclient.api; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* + * Listener interface for events on a particular key, including entry creating, deleting and value change. + */ Review Comment: nit, comment styling, for class I believe it should start with /** instead of /*. Please follow the java coding standard ########## meta-client/src/main/java/org/apache/helix/metaclient/api/DirectSubEntryChangeListener.java: ########## @@ -0,0 +1,29 @@ +package org.apache.helix.metaclient.api; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* + * Listener interface for direct children change event on a particular key. It includes new subentry creation or subentry deletion. The callback won't differentiate these types. + * For hierarchy key spaces like zookeeper, it refers to an entry's direct children nodes. + * For flat key spaces, it refers to keys that matches `prefix*separator`. + */ Review Comment: comment styling and wording ########## meta-client/src/main/java/org/apache/helix/metaclient/api/SubEntryChangeListener.java: ########## @@ -0,0 +1,40 @@ +package org.apache.helix.metaclient.api; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/* + * Listener interface for children change events on a particular key. It includes new subentry + * creation, subentry deletion, subentry data change and when the listener is removed. + * This listener type can only be registered as a persist listener. + * For hierarchy key spaces like zookeeper, it refers to an entry's entire subtree. + * For flat key spaces, it refers to keys that matches `prefix*`. + */ Review Comment: same ########## meta-client/src/main/java/org/apache/helix/metaclient/api/DataChangeListener.java: ########## @@ -24,9 +24,9 @@ */ public interface DataChangeListener { enum ChangeType { - NODE_CREATED, // Node created of the specific path that the listener register to - NODE_DELETED, // Node deleted of the specific path that the listener register to - VALUE_UPDATE // Node value updated + ENTRY_CREATED, // Node created of the specific path that the listener register to + ENTRY_DELETED, // Node deleted of the specific path that the listener register to + ENTRY_UPDATE // Node value updated Review Comment: nit, might need to update the comments accordingly, node -> entry and children -> sub entry -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
