xyuanlu commented on code in PR #2249: URL: https://github.com/apache/helix/pull/2249#discussion_r1028441074
########## meta-client/src/main/java/org/apache/helix/metaclient/api/DirectChildSubscribeResult.java: ########## @@ -0,0 +1,45 @@ +package org.apache.helix.metaclient.api; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.util.List; + + +public class DirectChildSubscribeResult { + // A list of direct children names at the time when change is subscribed. + // It includes only one level child name, does not include further sub children names. + private final List<String> _children; + + // true means the listener is registered successfully. + private final boolean _isRegistered; Review Comment: Per offline discussion, let's keep the behavior align with our current ZkClient APIs for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
