xyuanlu commented on code in PR #2249:
URL: https://github.com/apache/helix/pull/2249#discussion_r1055071501


##########
meta-client/src/main/java/org/apache/helix/metaclient/api/AsyncCallback.java:
##########
@@ -22,28 +22,58 @@
 import java.util.List;
 
 /**
- * An asynchronous callback is deferred to invoke after an async CRUD 
operation returns.
- * The corresponding callback is registered when async CRUD API is invoked.
+ * An asynchronous callback is deferred to invoke after an async CRUD 
operation finish and return.
+ * The corresponding callback is registered when async CRUD API is invoked. 
Implementation processes
+ * the result of each CRUD call. It should check return code and perform 
accordingly.
  */
+// TODO: define return code. failure code should map to MetaClient exceptions.
 public interface AsyncCallback {

Review Comment:
   defaultCallback and CancellableAsyncCallback are Helix introduced wrapper.  
We do not need this for generic ZK user



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to