xyuanlu commented on code in PR #2291:
URL: https://github.com/apache/helix/pull/2291#discussion_r1030108587
##########
meta-client/src/main/java/org/apache/helix/metaclient/constants/MetaClientConstants.java:
##########
@@ -0,0 +1,16 @@
+package org.apache.helix.metaclient.constants;
+
+public interface MetaClientConstants {
Review Comment:
I followed the current Helix constants class and uses interface class. It
seems to be an anti pattern behavior after some research.
Changed to a final class with private constructor.
##########
meta-client/src/main/java/org/apache/helix/metaclient/constants/MetaClientConstants.java:
##########
@@ -0,0 +1,16 @@
+package org.apache.helix.metaclient.constants;
+
+public interface MetaClientConstants {
Review Comment:
TFTR. Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
