qqu0127 commented on code in PR #2291:
URL: https://github.com/apache/helix/pull/2291#discussion_r1039815890


##########
meta-client/src/main/java/org/apache/helix/metaclient/constants/MetaClientConstants.java:
##########
@@ -0,0 +1,16 @@
+package org.apache.helix.metaclient.constants;
+
+public interface MetaClientConstants {
+
+  // Stop retrying when we reach timeout
+  int DEFAULT_OPERATION_RETRY_TIMEOUT = Integer.MAX_VALUE;

Review Comment:
   Chatted offline, there is a similar change in current behavior 
https://github.com/apache/helix/pull/2293 
   A shorter default timeout makes more sense and we should keep in sync



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to