NealSun96 opened a new pull request, #2319: URL: https://github.com/apache/helix/pull/2319
### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: Fixes #2287 #2062 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: This is a combined PR of https://github.com/apache/helix/pull/2189, https://github.com/apache/helix/pull/2302, and https://github.com/apache/helix/pull/2318. All 3 PRs were merged to the feature branch and is now merging into master. All reviews from previous PRs apply to this PR. This PR implements a redesign to WAGED pipeline, which includes the following: 1. Introducing the emergency rebalance process. 2. Move partial rebalance to asynchronous. 3. Add conditions to skip rebalance overwrite. 4. Move cluster model generation to asynchronous global rebalance thread. 5. Changes some API to AssignmentMetadata for operation purposes. For example, the persistX functions no longer include the "check for same assignment" logic for early termination. This allows us to a) accurately track write latency and b) tie boolean return values to actual persist failures. The overall effect is increased pipeline performance, which has been confirmed in simulation tests. ### Tests - [x] The following tests are written for this issue: testRebalanceOverwriteTrigger, testEmergencyRebalance - The following is the result of the "mvn test" command on the appropriate module: (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.) ### Changes that Break Backward Compatibility (Optional) - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.) ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
