NealSun96 commented on code in PR #2319:
URL: https://github.com/apache/helix/pull/2319#discussion_r1047761658
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/AssignmentMetadataStore.java:
##########
@@ -50,6 +50,7 @@ public class AssignmentMetadataStore {
private String _bestPossiblePath;
protected Map<String, ResourceAssignment> _globalBaseline;
protected Map<String, ResourceAssignment> _bestPossibleAssignment;
+ protected int _bestPossibleVersion = 0;
Review Comment:
That's a good point: shouldn't volatile be used for a lot more variables
here, such as _bestPossibleAssignment as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
