xyuanlu commented on code in PR #2327:
URL: https://github.com/apache/helix/pull/2327#discussion_r1061956379
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -155,12 +209,15 @@ public void asyncTransaction(Iterable iterable,
AsyncCallback.TransactionCallbac
@Override
public boolean connect() {
- return false;
+ // TODO: This is a tempp impl for test only. no proper event handling and
error handling.
+ _zkClient.connect(Integer.MAX_VALUE, _zkClient);
+ return true;
Review Comment:
Thanks for bring this up. this connect is not called in test as of now. I
plan to change it after your PR that includes constructor change is added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
