desaikomal commented on code in PR #2327:
URL: https://github.com/apache/helix/pull/2327#discussion_r1065201883
##########
meta-client/src/main/java/org/apache/helix/metaclient/api/MetaClientInterface.java:
##########
@@ -36,7 +36,11 @@ enum EntryMode {
// The node will not be automatically deleted when the last sub-entry of
the node is deleted.
// The node is an ephemeral node.
- CONTAINER
+ CONTAINER,
+
+ // If the entry is not modified within the TTL and has no children it will
become a candidate
+ // to be deleted by the server at some point in the future.
Review Comment:
terminology is still very ZK like. Pure KV doesn't have concept of "child"
node. I understand that for ZK, we need to maintain as Helix is using it.
##########
meta-client/src/main/java/org/apache/helix/metaclient/api/MetaClientInterface.java:
##########
@@ -143,7 +152,7 @@ public int getVersion() {
* @eturn Return a list of children keys. Return direct child name only for
hierarchical key
* space, return the whole sub key for non-hierarchical key space.
*/
- List<String> getDirestChildrenKeys(final String key);
+ List<String> getDirectChildrenKeys(final String key);
Review Comment:
this is very confusing. for non-hierarchical, shouldn't it return
NotImplemented ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
