xyuanlu commented on code in PR #2327:
URL: https://github.com/apache/helix/pull/2327#discussion_r1066157944
##########
meta-client/src/main/java/org/apache/helix/metaclient/api/MetaClientInterface.java:
##########
@@ -332,9 +349,9 @@ void asyncCreate(final String key, final T data, final
EntryMode mode,
/**
* Maintains a connection with underlying metadata service based on config
params. Connection
* created by this method will be used to perform CRUD operations on
metadata service.
- * @return True if connection is successfully established.
+ * @Throws MetaClientException when failed to connect.
*/
- boolean connect();
+ void connect();
Review Comment:
TFTR. Added a `todo`. Will add the connect/disconnect part in following PR
since it needs a bit more error handling and it is orthogonal to this CRUD
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
