rahulrane50 commented on code in PR #2344:
URL: https://github.com/apache/helix/pull/2344#discussion_r1087265251
##########
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java:
##########
@@ -109,9 +157,21 @@ public class ClusterStatusMonitor implements
ClusterStatusMonitorMBean {
private final Map<String, JobMonitor> _perTypeJobMonitorMap = new
ConcurrentHashMap<>();
+ /**
+ * Missing top state resource map:
resourceName-><PartitionName->startTimeOfMissingTopState>
+ */
+ private final Map<String, Map<String, Long>> _missingTopStateResourceMap =
new ConcurrentHashMap<>();
+ private final AsyncMissingTopStateMonitor _asyncMissingTopStateMonitor = new
AsyncMissingTopStateMonitor(_missingTopStateResourceMap);
+
public ClusterStatusMonitor(String clusterName) {
_clusterName = clusterName;
_beanServer = ManagementFactory.getPlatformMBeanServer();
+ /**
+ * Start a async thread for each cluster which keeps monitoring missing
top states of any resource for a cluster.
+ * This thread will keep on iterating over resources and report
missingTopStateDuration for them until there are at
+ * least one resource with missing top state for a cluster.
+ */
+ _asyncMissingTopStateMonitor.start();
Review Comment:
I checked the flow and async thread should be tied with ClusterStatusMonitor
thread. That means currently, all beans are registered in active() method and
unregistered or reset in reset() method. So whenever Helix controller will
activate cluster status monitor it should start this async thread and whenever
helix controller stops/resets cluster status monitor it should stop this async
thread. So just to re-iterate whenever cluster status monitor is reset() it
has to be activated first by caller which will make sure that this async thread
will be started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
