rahulrane50 commented on code in PR #2344:
URL: https://github.com/apache/helix/pull/2344#discussion_r1088529228
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -85,6 +85,9 @@ private void
updateTopStateStatus(ResourceControllerDataProvider cache,
if (cache.getClusterConfig() != null) {
durationThreshold =
cache.getClusterConfig().getMissTopStateDurationThreshold();
}
+ if (clusterStatusMonitor != null) {
+
clusterStatusMonitor.updateMissingTopStateDurationThreshold(durationThreshold);
Review Comment:
That's correct if threshold is not set then it's no-op thread. But in this
case most of the metrics are not reported so i'm assuming that this config is
used commonly.
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -85,6 +85,9 @@ private void
updateTopStateStatus(ResourceControllerDataProvider cache,
if (cache.getClusterConfig() != null) {
durationThreshold =
cache.getClusterConfig().getMissTopStateDurationThreshold();
}
+ if (clusterStatusMonitor != null) {
+
clusterStatusMonitor.updateMissingTopStateDurationThreshold(durationThreshold);
Review Comment:
That's correct if threshold is not set then it's no-op thread. But in this
case most of the metrics related to top state are not reported so i'm assuming
that this config is used commonly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
