Marcosrico opened a new pull request, #2377:
URL: https://github.com/apache/helix/pull/2377

   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the 
PR description:
   
   https://github.com/apache/helix/issues/2237
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   
   Implementation of Container Node in ZkMetaClient.
   
   ### Tests
   
   - [x] The following tests are written for this issue:
   
   Unit test `createContainer()`.
   Note: Cannot test end to end behavior (i.e. that the container node 
disappears after it's children are deleted) as the current setup of the zk 
server doesn't permit it. This is also a issue in HelixZkClient testbase. 
However, it has been tested and confirmed that the actual behavior does work 
(in native zkclient) and is merely a unit testing bug. Will track and fix this 
effort in the future but current implementation will use existing test base 
framework.
   
   - The following is the result of the "mvn test" command on the appropriate 
module:
   
   (If CI test fails due to known issue, please specify the issue and test PR 
locally. Then copy & paste the result of "mvn test" to here.)
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to