Marcosrico commented on code in PR #2377:
URL: https://github.com/apache/helix/pull/2377#discussion_r1107526612
##########
meta-client/src/test/java/org/apache/helix/metaclient/impl/zk/TestZkMetaClient.java:
##########
@@ -67,8 +68,16 @@ public class TestZkMetaClient {
private ZkServer _zkServer;
+ /**
+ * Creates local Zk Server
+ * Note: Cannot test container / TTL node end to end behavior as
+ * the zk server setup doesn't allow for that. However, the actual
+ * behavior has been verified to work on native ZK Client.
Review Comment:
Of course! And no to both. I believe the `ZooKeeperServer `class exists in
Zk just to create servers easier but with less functionalities. And we do not
need to upgrade any ZK version as the classes mentioned above are available in
the current version of zk that we use.
Just for additional information, I was able to successfully create a zk
server using `ZooKeeperServerMain.java,` but replacing the existing framework
and modifying it so it's thread safe would require more bandwidth than
available. And it is not a major issue so the priority is low.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
