desaikomal opened a new pull request, #2384: URL: https://github.com/apache/helix/pull/2384
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: ### Description Helix has been using JDK 1.8. We want to move to latest JDK but prior to that, we can use JDK11 as intermediate step. This will help us remain current and use all the language optimizations for performance improvements. ### Tests - The following is the result of the "mvn test" command on the appropriate module: [ERROR] Failures: [ERROR] TestNoThrottleDisabledPartitions.testDisablingTopStateReplicaByDisablingInstance:98 expected:<false> but was:<true> [ERROR] TestNoThrottleDisabledPartitions.testNoThrottleOnDisabledInstance:231->setupEnvironment:317->setupCluster:436 » ZkClient [ERROR] TestP2PNoDuplicatedMessage.testP2PStateTransitionEnabled:180 expected:<true> but was:<false> [ERROR] TestMultiZkConnectionConfig>MultiZkTestBase.afterClass:137 expected:<true> but was:<false> [ERROR] TestMultiZkConnectionConfig.testZKHelixManager:295->Object.wait:328->Object.wait:-2 » ThreadTimeout [ERROR] TestWagedRebalanceFaultZone.testAddZone:270->validate:318->validateZoneAndTagIsolation:342 expected:<3> but was:<2> [ERROR] TestTaskStateModelFactory.testZkClientCreationMultiZk:80 » Bind Address alread... [INFO] [ERROR] Tests run: 1325, Failures: 7, Errors: 0, Skipped: 6 I ran all the 7 failures as independent test-runs. Some tests passed on running while some failed. I took a fresh code branch with no changes and ran the same failed tests against it and they failed there as well. So between re-run and clean branch, there are NO NEW failures. ### Changes that Break Backward Compatibility (Optional) - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.) ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
