rahulrane50 commented on code in PR #2384:
URL: https://github.com/apache/helix/pull/2384#discussion_r1120572590
##########
helix-rest/src/main/java/org/apache/helix/rest/server/HelixRestServer.java:
##########
@@ -283,7 +283,8 @@ private void cleanupResourceConfigs() {
}
}
- public void setupSslServer(int port, SslContextFactory sslContextFactory) {
+
+ public void setupSslServer(int port, SslContextFactory.Server
sslContextFactory) {
Review Comment:
Neat : If Now parent factory class is deprecated and directly server and
client class are encouraged to access then should we rename this variable as
well to "sslContextServer"? Also may be update documentation/comments here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
