jiajunwang commented on code in PR #2477:
URL: https://github.com/apache/helix/pull/2477#discussion_r1185279002
##########
helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java:
##########
@@ -83,15 +83,15 @@ public void onBecomeRunningFromInit(Message msg,
NotificationContext context) {
public String onBecomeStoppedFromRunning(Message msg, NotificationContext
context) {
String taskPartition = msg.getPartitionName();
if (_taskRunner == null) {
- throw new IllegalStateException(String.format(
Review Comment:
I believe we prefer to use String.format as a convention. But I'm also aware
of the potential performance difference. Shall we update this recommendation
(and I'm not sure if we do have such a document talk about it explicitly)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
