desaikomal commented on code in PR #2477:
URL: https://github.com/apache/helix/pull/2477#discussion_r1185288232
##########
helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java:
##########
@@ -83,15 +83,15 @@ public void onBecomeRunningFromInit(Message msg,
NotificationContext context) {
public String onBecomeStoppedFromRunning(Message msg, NotificationContext
context) {
String taskPartition = msg.getPartitionName();
if (_taskRunner == null) {
- throw new IllegalStateException(String.format(
Review Comment:
I always love to hear from @jiajunwang - i think, we should update the
documentation. let me know where the guideline doc is and i will update it.
btw.. while you are reviewing, can you also look at other PRs? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
