parakhnr commented on code in PR #2514:
URL: https://github.com/apache/helix/pull/2514#discussion_r1213692749
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -218,6 +217,8 @@ private void
reportTopStateExistence(ResourceControllerDataProvider cache, Curre
// we observed an entire top state handoff process
reportSingleTopStateHandoff(cache, lastTopStateInstance,
currentTopStateInstance,
Review Comment:
I feel like we should modify the if check to just use `if
(lastTopStateInstance !=null)` and reuse the `reportSingleTopStateHandoff`
function for both usecases instead by getting rid of the if statement that
returns on `topStateInstance == currentTopStateInstance` in
`reportSingleTopStateHandoff` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
