rahulrane50 commented on code in PR #2514:
URL: https://github.com/apache/helix/pull/2514#discussion_r1213697929
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -218,6 +217,8 @@ private void
reportTopStateExistence(ResourceControllerDataProvider cache, Curre
// we observed an entire top state handoff process
reportSingleTopStateHandoff(cache, lastTopStateInstance,
currentTopStateInstance,
Review Comment:
+1 Why do need two branches here? Even if we simply remove this if condition
as well as first check in reportSingleTopStateHandoff about same instance then
also it will automatically take care of this case right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
