Marcosrico opened a new pull request, #2580: URL: https://github.com/apache/helix/pull/2580
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: LockClient currently uses ZNRecord serializer. Abstracting away any zookeeper specifics and keeping the code easier to understand, LockInfoSerializer is created to serialize and deserialize the LockInfo object used in LockClient. Furthermore, the old LockInfo structure would show the simplefields as their own separate fields in ZooKeeper. Changing that so the ZNRecord represents all parameters of the lock in ZooKeeper as a field in SimpleFields. ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: Created the LockInfoSerializer which extends the ZNRecordSerializer. Modified LockClient to use this serializer and updated the LockClient test case to show that it works. Modified the LockInfo object so that all fields appear as fields in simplefield in Zookeeper as opposed to it's own separate field. ### Tests - [ ] The following tests are written for this issue: LockClientTest.java - The following is the result of the "mvn test" command on the appropriate module: (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
